justintsus-experiment Public
{ "notes": [ "A: evil ctx values in SQL text: 0", "B: evil ctx values in SQL text: 0", "A heavy issues: 32 terms, 66 params (+2 for LIMIT/OFFSET on the page = 68); where length 1578", "B heavy issues: 32 terms, 66 params (+2 for LIMIT/OFFSET on the page = 68); where length 2104", "A heavy pulls: 32 terms, 66 params (+2 for LIMIT/OFFSET on the page = 68); where length 3568", "B heavy pulls: 32 terms, 66 params (+2 for LIMIT/OFFSET on the page = 68); where length 4474", "A issues: most params per term 2 (crash) -> 32 distinct such terms = 66 params + 2 (LIMIT, OFFSET) = 68", "B issues: most params per term 2 (crash) -> 32 distinct such terms = 66 params + 2 (LIMIT, OFFSET) = 68", "A pulls: most params per term 2 (author:fixer) -> 32 distinct such terms = 66 params + 2 (LIMIT, OFFSET) = 68", "B pulls: most params per term 2 (author:fixer) -> 32 distinct such terms = 66 params + 2 (LIMIT, OFFSET) = 68", "fuzz: 20400 (input, target) pairs, 0 differ", "A timing: 10k random queries median 13.5 ms (min 13.5, max 14.4); worst-case 1024-char inputs, us per parse: 7.1, 22.8, 37.1, 21.5, 15.5, 14.0, 18.5", "B timing: 10k random queries median 18.8 ms (min 18.5, max 19.4); worst-case 1024-char inputs, us per parse: 8.9, 12.0, 30.1, 21.4, 10.6, 15.6, 9.0", "A odd args: parse(undefined): ok=true | parse(null): ok=true | parse(123): ok=true | parse(x, 'bogus'): ok=true | toSql(viewerId undefined): params=[\"repo-1\",\"org-1\"] | toSql(now NaN, <7d): params=[\"repo-1\",\"org-1\",null] | toSql(issues query, pulls-looking ctx): params=[\"repo-1\",\"org-1\",\"bug\"]", "B odd args: parse(undefined): THROWS TypeError: Cannot read properties of undefined (reading 'length') | parse(null): THROWS TypeError: Cannot read properties of null (reading 'length') | parse(123): ok=true | parse(x, 'bogus'): ok=true | toSql(viewerId undefined): params=[\"repo-1\",\"org-1\",null] | toSql(now NaN, <7d): params=[\"repo-1\",\"org-1\",null] | toSql(issues query, pulls-looking ctx): params=[\"repo-1\",\"org-1\",\"bug\"]" ], "crashes": { "A": [], "B": [ { "where": "sqlite", "input": "label:bug", "target": "issues", "e": "Error: malformed JSON", "sql": "issues.repo_id = ? AND issues.org_id = ? AND (EXISTS (SELECT 1 FROM json_each(issues.labels) WHERE json_each.value = ?))" }, { "where": "sqlite", "input": "-label:bug", "target": "issues", "e": "Error: malformed JSON", "sql": "issues.repo_id = ? AND issues.org_id = ? AND (NOT (EXISTS (SELECT 1 FROM json_each(issues.labels) WHERE json_each.value = ?)))" }, { "where": "sqlite", "input": "no:label", "target": "issues", "e": "Error: malformed JSON", "sql": "issues.repo_id = ? AND issues.org_id = ? AND (json_array_length(issues.labels) = 0)" } ] }, "props": { "A": [], "B": [], "nA": 0, "nB": 0 }, "diffs": { "bad-json-labels": { "n": 3, "items": [ { "label": "bad-json-labels", "input": "label:bug", "target": "issues", "ctx": "CTX", "A": "ok canon=\"label:bug\" rows=[3,2,1,8]", "B": "CRASH" }, { "label": "bad-json-labels", "input": "-label:bug", "target": "issues", "ctx": "CTX", "A": "ok canon=\"-label:bug\" rows=[7,5,4,6,77]", "B": "CRASH" }, { "label": "bad-json-labels", "input": "no:label", "target": "issues", "ctx": "CTX", "A": "ok canon=\"no:label\" rows=[4,6,77]", "B": "CRASH" } ] } }}