justintsus-experiment Public
// unit/search/query (apps/web/src/search/api.ts): the query language's parser and canonical form:// terms, quotes, negation, qualifiers per target, values, dates, errors with their spans and their// order, the limits, and that every valid input's canonical form round-trips.import { test } from "node:test";import assert from "node:assert/strict";import { parseQuery, serializeQuery, toSql, type QueryError, type Target } from "../../../apps/web/src/search/api.ts";const canon = (x: string, t: Target = "issues"): string => { const r = parseQuery(x, t); assert.ok(r.ok, `${JSON.stringify(x)} should parse: ${r.ok ? "" : JSON.stringify(r.errors)}`); return serializeQuery(r.query);};const errs = (x: string, t: Target = "issues"): Array<[string, number, number]> => { const r = parseQuery(x, t); assert.ok(!r.ok, `${JSON.stringify(x)} should not parse`); for (const e of r.errors) assert.ok(e.message.length > 0); return r.errors.map((e: QueryError) => [e.code, e.start, e.end]);};const CTX = { repoId: "r1", orgId: "o1", viewerId: "11111111-1111-4111-8111-111111111111", now: 1_800_000_000_000 };test("terms: whitespace of every kind separates, free text, phrases, numbers and qualifiers", () => { assert.equal(canon(""), ""); assert.equal(canon(" \t\n "), ""); assert.equal(canon("a b c"), "a b c"); assert.equal(canon('"bug"'), "bug"); assert.equal(canon('"label:bug"'), '"label:bug"'); assert.equal(canon('"#12"'), '"#12"'); assert.equal(canon("#12"), "#12"); assert.equal(canon("#0 #1234567890"), "#0 #1234567890"); assert.equal(canon("12:30 a1:b :x"), "12:30 a1:b :x"); assert.equal(canon("OR"), "OR"); assert.equal(canon("-"), '"-"'); assert.equal(canon("- -"), '"-"'); assert.equal(canon("-foo --bar"), '-foo -"-bar"'); assert.equal(canon('"two spaces"'), '"two spaces"'); assert.equal(canon('"a \\"q\\" b\\\\c \\d"'), '"a \\"q\\" b\\\\c \\\\d"'); assert.equal(canon('"x\\y"'), "x\\y"); assert.equal(canon("x\\y"), "x\\y"); assert.equal(canon('-"some phrase"'), '-"some phrase"');});test("qualifiers: keys and values are normalized, duplicates dropped, order kept", () => { assert.equal(canon('IS:Open label:" Needs Review " author:@ME updated:<007D'), 'is:open label:"needs review" author:@me updated:<7d'); assert.equal(canon("is:open bug is:open BUG"), "is:open bug BUG"); assert.equal(canon("-label:x -label:X label:x"), "-label:x label:x"); assert.equal(canon("no:LABEL"), "no:label"); assert.equal(canon("author:AAAAAAAA-BBBB-4CCC-8DDD-EEEEEEEEEEEE"), "author:aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee"); assert.equal(canon("author:Deploy-Bot"), "author:deploy-bot"); assert.equal(canon("sort:Updated-Asc sort:updated-asc"), "sort:updated-asc"); assert.equal(canon("is:merged is:draft review-requested:@me -author:bot", "pulls"), "is:merged is:draft review-requested:@me -author:bot"); assert.equal(canon('label:"bug"'), "label:bug"); assert.equal(canon("created:>=2026-10-01 created:2026-10-01..* updated:*..2026-01-31 created:2026-02-28..2026-02-28"), "created:>=2026-10-01 created:2026-10-01..* updated:*..2026-01-31 created:2026-02-28..2026-02-28"); assert.equal(canon("updated:>=0001W created:<=12H"), "updated:>=1w created:<=12h");});test("errors: one per invalid term, spanning it, in input order, in the documented check order", () => { assert.deepEqual(errs("assignee:me repo:x milestone:1"), [["unknown_qualifier", 0, 11], ["unknown_qualifier", 12, 18], ["unknown_qualifier", 19, 30]]); assert.deepEqual(errs("http://x"), [["unknown_qualifier", 0, 8]]); assert.deepEqual(errs("label:bug no:label", "pulls"), [["unsupported_qualifier", 0, 9], ["unsupported_qualifier", 10, 18]]); assert.deepEqual(errs("review-requested:@me"), [["unsupported_qualifier", 0, 20]]); assert.deepEqual(errs('label: author:""'), [["empty_value", 0, 6], ["empty_value", 7, 16]]); assert.deepEqual(errs('"" " "'), [["empty_value", 0, 2], ["empty_value", 3, 7]]); assert.deepEqual(errs("-no:label -sort:created-asc -created:2026-01-01 -updated:<7d"), [ ["negation_not_allowed", 0, 9], ["negation_not_allowed", 10, 27], ["negation_not_allowed", 28, 47], ["negation_not_allowed", 48, 60], ]); assert.deepEqual(errs("-#5"), [["negation_not_allowed", 0, 3]]); // the order: unknown before negation, unsupported before empty, empty before negation assert.deepEqual(errs("-assignee:"), [["unknown_qualifier", 0, 10]]); assert.deepEqual(errs("-label:", "pulls"), [["unsupported_qualifier", 0, 7]]); assert.deepEqual(errs("-sort:"), [["empty_value", 0, 6]]); assert.deepEqual(errs("is:merged is:draft sort:comments-desc"), [["bad_value", 0, 9], ["bad_value", 10, 18]]); assert.deepEqual(errs("sort:comments-desc", "pulls"), [["bad_value", 0, 18]]); assert.deepEqual(errs("is:all no:labels author:@someone author:a_b label:-x"), [ ["bad_value", 0, 6], ["bad_value", 7, 16], ["bad_value", 17, 32], ["bad_value", 33, 43], ["bad_value", 44, 52], ]); assert.deepEqual(errs(`label:${"a".repeat(33)}`), [["bad_value", 0, 39]]); assert.deepEqual(errs("sort:created-asc sort:created-desc sort:created-asc"), [["conflict", 17, 34]]);});test("dates: real UTC days 1970 to 9999, operators, ranges and ages", () => { for (const bad of [ "7d", "=2026-01-01", "2026-1-01", "2026-02-30", "2025-02-29", "1969-12-31", "10000-01-01", "*..*", "2026-02-01..2026-01-31", "<0d", "<10000d", "<7m", "<7d..*", "2026-01-01..", "..2026-01-01", "<", ">=", "<=7d7d", "2026-01-01T00:00", " 2026-01-01", ]) { assert.deepEqual(errs(`created:"${bad}"`).map((e) => e[0]), ["bad_date"], bad); } assert.equal(canon("created:2024-02-29 updated:9999-12-31 created:1970-01-01"), "created:2024-02-29 updated:9999-12-31 created:1970-01-01"); const day = Date.UTC(2026, 9, 1); const D = 86_400_000; const w = (x: string) => { const r = parseQuery(x, "issues"); assert.ok(r.ok); return toSql(r.query, CTX); }; assert.deepEqual(w("created:2026-10-01").params.slice(2), [day, day + D]); assert.deepEqual(w("created:>2026-10-01").params.slice(2), [day + D]); assert.deepEqual(w("created:>=2026-10-01").params.slice(2), [day]); assert.deepEqual(w("created:<2026-10-01").params.slice(2), [day]); assert.deepEqual(w("created:<=2026-10-01").params.slice(2), [day + D]); assert.deepEqual(w("created:2026-10-01..2026-10-03").params.slice(2), [day, day + 3 * D]); assert.deepEqual(w("updated:<7d").params.slice(2), [CTX.now - 7 * D]); assert.deepEqual(w("updated:<2w").params.slice(2), [CTX.now - 14 * D]); assert.deepEqual(w("updated:>=3h").params.slice(2), [CTX.now - 3 * 3_600_000]); assert.match(w("updated:<7d").where, /updated_at > \?\)$/); assert.match(w("updated:<=7d").where, /updated_at >= \?\)$/); assert.match(w("updated:>7d").where, /updated_at < \?\)$/); assert.match(w("updated:>=7d").where, /updated_at <= \?\)$/);});test("quotes: an unterminated quote stops parsing, an unexpected one spans to the next space", () => { assert.deepEqual(errs('is:open "abc def'), [["unterminated_quote", 8, 16]]); assert.deepEqual(errs('assignee:x -"abc label:'), [["unknown_qualifier", 0, 10], ["unterminated_quote", 11, 23]]); assert.deepEqual(errs('label:"abc'), [["unterminated_quote", 0, 10]]); assert.deepEqual(errs('"a\\"'), [["unterminated_quote", 0, 4]]); assert.deepEqual(errs('ab"c d" x'), [["unexpected_quote", 0, 4], ["unexpected_quote", 5, 7]]); assert.deepEqual(errs('"a"b c'), [["unexpected_quote", 0, 4]]); assert.deepEqual(errs('label:"x"y is:bad'), [["unexpected_quote", 0, 10], ["bad_value", 11, 17]]); assert.deepEqual(errs('lab el:"x"'), [["unknown_qualifier", 4, 10]]); assert.deepEqual(errs('lab e1:"x"'), [["unexpected_quote", 4, 10]]); assert.deepEqual(errs('-label:x"'), [["unexpected_quote", 0, 9]]); assert.equal(canon('label:"needs review" -label:"won t fix"'), 'label:"needs review" -label:"won t fix"');});test("limits: too long and too many terms are reported alone", () => { const long = "a".repeat(1025); const r = parseQuery(long, "issues"); assert.ok(!r.ok); assert.deepEqual(r.errors.map((e) => [e.code, e.start, e.end]), [["too_long", 0, 1025]]); assert.ok(parseQuery("a".repeat(1024), "issues").ok); const terms = Array.from({ length: 32 }, () => "assignee:x"); assert.equal(errs(terms.join(" ")).length, 32); const many = [...terms, "x", "y"].join(" "); assert.deepEqual(errs(many), [["too_many_terms", many.indexOf(" x ") + 1, many.length]]); // counted as written, duplicates included assert.equal(errs(Array.from({ length: 33 }, () => "bug").join(" "))[0][0], "too_many_terms"); assert.ok(parseQuery(Array.from({ length: 32 }, () => "bug").join(" "), "issues").ok);});test("parseQuery never throws and every accepted input round-trips through its canonical form", () => { const pieces = [ "is:open", "IS:CLOSED", "is:merged", "is:draft", "label:Bug", 'label:"a b"', "no:label", "author:@me", "author:bot", "review-requested:@ME", "sort:updated-asc", "created:>=2026-01-01", "updated:<07d", "created:2026-01-01..*", "#7", "word", '"a phrase"', '"-x"', '"x:y"', "-", "-w", '-"p q"', '"\\\\"', '"\\""', "a\\b", '"', "x\"", ":", "-:", "a:", '""', " ", " ", "\t", "é", "ß", "K", "#", "-#1", "--", '"is:open"', "OR", ]; let seed = 7; const rnd = (n: number) => { seed = (seed * 1103515245 + 12345) % 2147483648; return seed % n; }; for (let i = 0; i < 4000; i++) { const n = 1 + rnd(6); let s = ""; for (let j = 0; j < n; j++) s += pieces[rnd(pieces.length)] + [" ", "", " ", " "][rnd(4)]; for (const t of ["issues", "pulls"] as const) { const r = parseQuery(s, t); if (!r.ok) { assert.ok(r.errors.length > 0); for (let k = 0; k < r.errors.length; k++) { const e: QueryError = r.errors[k]; assert.ok(e.start >= 0 && e.start < e.end && e.end <= s.length, JSON.stringify([s, e])); if (k) assert.ok(e.start >= r.errors[k - 1].end); } continue; } const c = serializeQuery(r.query); const r2 = parseQuery(c, t); assert.ok(r2.ok, JSON.stringify([s, c])); assert.equal(serializeQuery(r2.query), c); assert.deepEqual(toSql(r2.query, CTX), toSql(r.query, CTX)); } } for (const weird of [null, undefined, 12, {}, "\ud800", "\"\\", "\\"]) { assert.doesNotThrow(() => parseQuery(weird as unknown as string, "issues")); }});